Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback 'onStepBegin' #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

roedll
Copy link

@roedll roedll commented Nov 26, 2020

In our use case we need the information when a certain step is displayed.
Thus we added another callback called onStepBegin

@apksherlock
Copy link
Contributor

Hello.
Sorry for the late reply. We thank you for you contribution.
We will discuss in the future, if we are willing to keep this feature. If so, we will let you know. For the moment I'll leave it open.

@apksherlock apksherlock added enhancement New feature or request feature labels Dec 29, 2020
Comment on lines +206 to +210
is QuestionStep -> {
Log.w ("ASDF", "step '${step?.id}': ${step.title} (${step.text})")
}
else ->
Log.w ("ASDF", "step '${step?.id}'")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would show a Toast or something in the View just to make sure view interactions do not break. But logs are fine as well 👍

@KlausNie
Copy link
Member

@roedll
Isn't this something that should be done with a custom step? Since you want to execute an action, when a specific step is called, that specific step should take care of that.

That should not be part of the "library" configuration, but rather the action of that step.

@roedll
Copy link
Author

roedll commented Feb 21, 2021

Thanks for the suggestion, but I think in our use case as custom step wouldn't help: We want to be able to present the questions also via Text-To-Speech to the user when they are displayed. So the already available steps are enough for us for now...

I think my description wasn't that clear in my original post ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants